Change the hierarchy issue messages #3016
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
because they are difficult to translate with the verb variable.
mikeshardmind
added
Changelog Entry: Pending
mikeshardmind
suggested changes
Sep 27, 2019
There was a problem hiding this comment.
Thanks! Changes like this to support i18n better are good to have.
If you can toss a brief changelog entry into this PR, we'll get it merged in.
If anything is unclear about the process there, please ask.
Flame442
requested changes
Sep 27, 2019
redbot/cogs/admin/admin.py
Outdated
| USER_HIERARCHY_ISSUE = _( | ||
| "I tried to {verb} {role.name} to {member.display_name} but that role" | ||
| HIERARCHY_ISSUE_REMOVE = _( | ||
| "I tried to remove {role.name} to {member.display_name} but that role" |
There was a problem hiding this comment.
This phrase should be "I tried to remove {role.name} from ..."
redbot/cogs/admin/admin.py
Outdated
| HIERARCHY_ISSUE_REMOVE = _( | ||
| "I tried to remove {role.name} to {member.display_name} but that role" | ||
| " is higher than my highest role in the Discord hierarchy so I was" | ||
| " unable to successfully add it. Please give me a higher role and " |
There was a problem hiding this comment.
This phrase should be "unable to successfully remove it."
redbot/cogs/admin/admin.py
Outdated
| ) | ||
|
|
||
| USER_HIERARCHY_ISSUE_REMOVE = _( | ||
| "I tried to remove {role.name} to {member.display_name} but that role" |
There was a problem hiding this comment.
Same issue as above, "from" and "remove".
|
I think I did everything right now :D |
mikeshardmind
approved these changes
Sep 27, 2019
Flame442
removed
the
Changelog Entry: Pending
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Description of the changes
Add custom messages for adding and removing roles. This removed the verb variable which makes it difficult to translate the messages.